Conversation
452a2e8 to
0a67fcc
Compare
…ed build and test processes.
| const stream = await navigator.mediaDevices.getUserMedia({ | ||
| audio: true, | ||
| video: { frameRate: 14 } | ||
| }); |
There was a problem hiding this comment.
Should we maybe have it a part of SDK?
Because we probably want to control the fps (e.g. in Safari 14 FPS => 15 FPS and its high) and there were a lot of pitfalls in it
There was a problem hiding this comment.
I don't think we should abstract the entire navigator.mediaDevices.getUserMedia() call or the full video configuration - clients should be able to control and adjust these to their specific needs.
That said, since we do care about the frameRate (especially its max value) and possibly the max width/height and/or aspectRatio of the stream, we could expose these as helpers, verify the inputs, or cap them at our allowed limits - and add an error or warning if needed.
wdyt?
There was a problem hiding this comment.
In terms of a backend I am torn between forcing max fps (i.e. dropping frames which arrive too early) or allowing any fps.
The former solution might be too strict (there is no problem if sometimes frames arrive a bit earlier or a bit late, but if we drop frames forcefully), hence we stick to the latter.
|
Since we're not publishing it right now, I'm going to merge it and handle all comments/feedback in follow-up PRs. |
No description provided.